.dat file viewer - Githubissues

jsettlers / settlers-remake

A Remake of "The Settlers III" for Windows, Linux, Mac and Android

http://www.settlers-android-clone.com

MIT License

356 stars 100 forks source link

.dat file viewer #682

Closed nptr closed 6 years ago

nptr commented 7 years ago

In order to get used to the project etc., i started playing around with the tooling a bit. I kind of cloned the DatFileTester and improved the UI and display of the images.

Maybe its useful :)

andreas-eberle commented 6 years ago

@nptr: Thanks for this! It's much easier to see the graphics with this.

I have three requests:

Can you tune the code a bit to get rid of all the warnings (I use IntelliJ IDEA)?
Can you reset the viewpoint when a new .dat file is selected? Beause I just scrolled a bit around and selected the next file and had to manually get back to the start position.
When I select a file containing images and then select a file without images, the images of the first file are still displayed. I think they should be removed from the view to not confuse the user.

nptr commented 6 years ago

@andreas-eberle

removed most of the warnings IntelliJ gave me. I left two "lambda with unnecessary code block" warnings to have the code consistent, and also the disclaimer formatting since thats how its used in the rest of the project.
viewport + zoomlevel reset on file change
fixed file selection issue that made it look like the canvas isn't cleared (was actually loading the same file again sometimes)

i hope its good now - for a dev tool :)

Simulant87 commented 6 years ago

Nice development. I used your File viewer to fix this bug: https://github.com/jsettlers/settlers-remake/pull/708