search

jsettlers / settlers-remake

A Remake of "The Settlers III" for Windows, Linux, Mac and Android
http://www.settlers-android-clone.com
MIT License
356 stars 100 forks source link

Update dependencies #697

Closed tom-pratt closed 6 years ago

tom-pratt commented 6 years ago

Updated gradle and android dependencies. Removed retro lambda.

The auto replay test failed in Travis. Not entirely sure what this is and haven't investigated!

andreas-eberle commented 6 years ago

The AutoReplay files are different because a lambda is serialized and since the lambda implementation has changed, this changes the bytes of the savegame. So it is an expected change.

I wanted to regenerate the auto replay files by running "jsettlers.integration.replay.RegenerateAutoReplayITReferences" in jsettlers.tools. However, I get a java.lang.ClassNotFoundException: org.junit.Assert exception. @tom-pratt: Do you know what's wrong here?

tom-pratt commented 6 years ago

Good idea. that's way tidier

tom-pratt commented 6 years ago

Actually putting the variables in gradle.properties is also slightly annoying. Theyre all interpreted as strings so you have to use .toInteger() when you want to use it for things like targetSdk. Both ways seem kind of hacky to me and stop the IDE package management from working!

andreas-eberle commented 6 years ago

I think we should then stick with the variables like we had it all the time.

andreas-eberle commented 6 years ago

I updated gradle to version 4.6. This fixed the problems I had with IntelliJ not being able to run SwingManagedJSettlers. I also changed the dependencies of jsettlers.main.swing to compile so they are included in the jar.