search

jsettlers / settlers-remake

A Remake of "The Settlers III" for Windows, Linux, Mac and Android
http://www.settlers-android-clone.com
MIT License
355 stars 101 forks source link

replace nextDrawableX with x++ #734

Closed paulwedeck closed 6 years ago

andreas-eberle commented 6 years ago

@michaelzangl: Why did you introduce this in the first place? I guess there was an idea to it?

paulwedeck commented 6 years ago

It has been introduced in bb15365a67b4a476391befa7e69de043c9fafac8

michaelzangl commented 6 years ago

It was meant to skip tiles of which we definitely know that there is noting to draw there.

This would have made rendering a bit faster.

andreas-eberle commented 6 years ago

"Nothing to draw" includes movables and objects?

andreas-eberle commented 6 years ago

@paulwedeck: Please only merge master into your Pull Request if there are conflicts with your PR. Otherwise, I can easily merge it with Github directly before I merge it into master. This way, we can prevent a ton of merge commits.

michaelzangl commented 6 years ago

@andreas-eberle Yes, no movables and no map objects.

paulwedeck commented 6 years ago

@andreas-eberle I will try