Game menu improvement

[tom-pratt]

Using a proper dialog for the game menu instead of the drop down list.

Menu for quit, save pause, game speed etc

[andreas-eberle]

@tom-pratt: When I select the original settlers folder, the game seems to do a long calculation (I guess, the calculation to see what settlers version it is). You show that something is happening. However, as a user, I have no idea what's happening. I think it might be better to display a message saying that the graphics are being indexed or so. What do you think?

[andreas-eberle]

I really like that you can change the game speed and directly see the outcome. Can we also allow to let the game run slower than normal speed? E.g. like 1/4th of the normal speed. That could be interesting for debugging and for new players that want to play it slow against the AI or so.

Another thing is that in multiplayer, the game speed cannot be changed. So it would be best to disable or not show the speed changer then.

[andreas-eberle]

I got the following exception once, which crashed the App:

E/AndroidRuntime: FATAL EXCEPTION: soundplayer4
                  Process: jsettlers.main.android, PID: 11247
                  java.lang.IllegalStateException: play() called on uninitialized AudioTrack.
                      at android.media.AudioTrack.play(AudioTrack.java:1962)
                      at go.graphics.android.AndroidSoundPlayer$PlaySoundTask.run(AndroidSoundPlayer.java:61)
                      at java.lang.Thread.run(Thread.java:764)
E/AndroidRuntime: FATAL EXCEPTION: soundplayer2
                  Process: jsettlers.main.android, PID: 11247
                  java.lang.IllegalStateException: play() called on uninitialized AudioTrack.
                      at android.media.AudioTrack.play(AudioTrack.java:1962)
                      at go.graphics.android.AndroidSoundPlayer$PlaySoundTask.run(AndroidSoundPlayer.java:61)
                      at java.lang.Thread.run(Thread.java:764)
E/AudioTrack: AudioFlinger could not create track, status: -12
E/AudioTrack: AudioFlinger could not create track, status: -12
E/AudioTrack-JNI: Error -12 initializing AudioTrack
E/android.media.AudioTrack: Error code -20 when initializing AudioTrack.

[andreas-eberle]

@tom-pratt: I really like the changes in the menu! Great work. Looking forward to the small fixes to get this into master!

[tom-pratt]

There's an open issue about that sound player crash. Still haven't ever really looked into that code!

[andreas-eberle]

@tom-pratt: One small thing: The "skip 1 minute button" should also be removed in multiplayer, since that isn't possible.

[andreas-eberle]

@tom-pratt: Can you do the small change from my last comment. Then I would merge this PR.

[tom-pratt]

Sorry havent been checking my emails! I'll do this soon

[andreas-eberle]

@tom-pratt: Did you find the time? It would be nice to get this into master :)

[tom-pratt]

I did it! Basically a one-liner, probably didn't need to take quite so many months. Good to see there has been some activity the last few weeks though.