search

jseutter / ofxparse

Ofx file format parser for Python
http://sites.google.com/site/ofxparse/
MIT License
204 stars 121 forks source link

Parse all aggregations #85

Closed egh closed 8 years ago

egh commented 9 years ago

I was missing transactions when using ledger-autosync. It turns out they were <TRANSFER> aggregations. This modifies ofxparse to parse all aggregation types (as defined in 2.1.1 of the spec (http://www.ofx.net/DownloadPage/Downloads.aspx)). It also changes the type attribute of the InvestmentTransaction to be a string instead of the less useful number.

Thanks!

egh commented 9 years ago

Related: #74 but this a little more comprehensive, and also includes a behavior change. Thank you!

egh commented 9 years ago

If you'd prefer, I can switch back to the enum-style type. I notice you are using that pattern elsewhere.

jseutter commented 8 years ago

I'm fine with the pattern you used. Thank you for the fixes (and tests)!

jseutter commented 8 years ago

I also added you to AUTHORS

egh commented 8 years ago

Thank you!