search

jseutter / ofxparse

Ofx file format parser for Python
http://sites.google.com/site/ofxparse/
MIT License
204 stars 121 forks source link

Fixed the parsing of ofx files containing amounts with comma rather than dots #90

Closed hobeika closed 8 years ago

hobeika commented 8 years ago

Some banks provide amounts with a comma rather than a dot for decimals. ofxparse ends up triggering exceptions like "Empty ledger balance" or "Invalid Transaction Amount".

Since locales can be tricky, it is easier to just replace the comma by a dot.

jseutter commented 8 years ago

Hi, I merged in another branch that handles commas in more spots than your pull requests. If ofxparse is still pertinent to you, could you test your .ofx files with an updated copy of master to see if it works?

hobeika commented 8 years ago

Jerry Seutter notifications@github.com writes:

Hi, I merged in another branch that handles commas in more spots than your pull requests. If ofxparse is still pertinent to you, could you test your .ofx files with an updated copy of master to see if it works?

That's great! My pull request was not of a very good quality.

Thanks for patching this!

I will try this and report if there is any troubles.

Thanks again for your time and the great work!

Vincent Hobeïka