search

jsgoupil / quickbooks-sync

Sync Quickbooks Desktop
MIT License
87 stars 40 forks source link

InvoiceAdd order wrong #32

Closed rogerfar closed 5 years ago

rogerfar commented 5 years ago

In the latest version the order of InvoiceAdd has changed (that's the only entity I verified, there might be others):

v0.2:

<?xml version="1.0" encoding="utf-8"?>
<?qbxml version="13.0"?>
<QBXML>
    <QBXMLMsgsRq onError="continueOnError">
        <InvoiceAddRq>
            <InvoiceAdd>
                <InvoiceLineAdd>
                    <Desc>TEST</Desc>
                </InvoiceLineAdd>
                <CustomerRef>
                    <ListID>80000003-1547478958</ListID>
                    <FullName>Arnett-Wessin Energy Services</FullName>
                </CustomerRef>
                <TemplateRef>
                    <ListID>80000002-1547157537</ListID>
                    <FullName>Intuit Professional Invoice</FullName>
                </TemplateRef>
                <TxnDate>2019-03-20</TxnDate>
                <RefNumber>3</RefNumber>
                <BillAddress />
                <TermsRef>
                    <ListID>80000001-1547157549</ListID>
                    <FullName>1% 10 Net 30</FullName>
                </TermsRef>
                <ShipDate>2019-03-20</ShipDate>
                <CustomerSalesTaxCodeRef>
                    <ListID>80000001-1547157549</ListID>
                    <FullName>G</FullName>
                </CustomerSalesTaxCodeRef>
            </InvoiceAdd>
        </InvoiceAddRq>
    </QBXMLMsgsRq>
</QBXML>

v0.11:

<?xml version="1.0" encoding="utf-8"?>
<?qbxml version="13.0"?>
<QBXML>
    <QBXMLMsgsRq onError="continueOnError">
        <InvoiceAddRq>
            <InvoiceAdd>
                <CustomerRef>
                    <ListID>80000003-1547478958</ListID>
                    <FullName>Arnett-Wessin Energy Services</FullName>
                </CustomerRef>
                <TemplateRef>
                    <ListID>80000002-1547157537</ListID>
                    <FullName>Intuit Professional Invoice</FullName>
                </TemplateRef>
                <TxnDate>2019-03-20</TxnDate>
                <RefNumber>3</RefNumber>
                <BillAddress />
                <TermsRef>
                    <ListID>80000001-1547157549</ListID>
                    <FullName>1% 10 Net 30</FullName>
                </TermsRef>
                <ShipDate>2019-03-20</ShipDate>
                <CustomerSalesTaxCodeRef>
                    <ListID>80000001-1547157549</ListID>
                    <FullName>G</FullName>
                </CustomerSalesTaxCodeRef>
                <InvoiceLineAdd>
                    <Desc>TEST</Desc>
                </InvoiceLineAdd>
            </InvoiceAdd>
        </InvoiceAddRq>
    </QBXMLMsgsRq>
</QBXML>

The former will error out in the QB validator saying that the order is wrong.

jsgoupil commented 5 years ago

Thanks. I have fixed this issue, I just have to release the Nuget package. I will try to do that this week!

jsgoupil commented 5 years ago

https://github.com/jsgoupil/quickbooks-sync/issues/29

jsgoupil commented 5 years ago

It's published now.