search

jsgoupil / quickbooks-sync

Sync Quickbooks Desktop
MIT License
89 stars 40 forks source link

The number of iterator records are now customizable. #9

Closed mscappini closed 9 years ago

mscappini commented 9 years ago

This is actually my first fork and pull request, as well as writing solid unit test code with Moq. Please let me know if anything needs to be changed or improved. I tried to follow the direction of @jsgoupil to write consistent unit tests.

Also, is there a better way to set that MaxReturned property without a harness class?

jsgoupil commented 9 years ago

Hey I have been a bit busy, I'll look at that soon!

mscappini commented 9 years ago

Great! I tried to get this in because now I am looking at changing the iterator size for my work project. :smile:

jsgoupil commented 9 years ago

@mscappini Since you asked the question about the Harness class test, have you thought of putting a property on the StepQueryWithIterator class that would take an integer MaxRequest?

mscappini commented 9 years ago

I hadn't considered it. I always feel that if you have a settable property that is supposed to be mirrored across two or more classes, those properties have the ability to become out of sync for one reason or another.

jsgoupil commented 9 years ago

@mscappini OK no problem.