jsh58 / Genrich

Detecting sites of genomic enrichment
MIT License
182 stars 27 forks source link

peak calling with repeats #78

Closed 809825706 closed 2 years ago

809825706 commented 2 years ago

Hi, thank you for such a great tools for ATACseq. I was using this tool for few months. in which, I found some strange results. I was foused about them, so I write this issue for asking for you help.

  1. When combining mutiple sample(repeats), there are more peaks than calling peaks with any one of them. if calling peak with repeats, should there be less peaks which is more universal in all repeats?

peaks

  1. is the output file standard narrowpeaks file? the qvalue in all my narrowpeaks is -1.

narrowpeak

all peak was calling use: Genrich -t ${treat}.bam -o ${out}/${name}.narrowPeak -j -y -r -m 30 -e MT -v

jsh58 commented 2 years ago

Your first question is addressed in the README and in #14, #19, #44, #51, #56, #64.

Your second question is addressed in #41.

809825706 commented 2 years ago

Your first question is addressed in the README and in #14, #19, #44, #51, #56, #64.

Your second question is addressed in #41.

thank you for your answer! with the limit to q-value(< 0.05), the peaks number was reduced significantly.

Genrich-pvalue

g3412

while the (combine) peaks from multiple repeats is more than the single repeat and the common peaks which is the overlapped in the single repeat results. the common peak was got just like the way that IDR does, which find out the sharing peaks in single repeat with loosing limit p-value. I have looked over issues you mentioned above. I think they can't answer my confusion. although Genrich can call peaks with multiple repeats, the results of it seem not equal to IDR. Or with multiple repeats, there should be smaller P-value limit?

jsh58 commented 2 years ago

although Genrich can call peaks with multiple repeats, the results of it seem not equal to IDR.

Genrich does not use IDR to call peaks with multiple repeats, as explained here.