search

jsh9 / cercis

https://pypi.org/project/cercis/
MIT License
14 stars 1 forks source link

Typo in pre-commit example from README.md #25

Closed syserr0r closed 1 year ago

syserr0r commented 1 year ago

Hopefully self-explanatory

*Sending signal to you that this should get the magical label to silence the CHANGELOG entry check.*

jsh9 commented 1 year ago

Thanks @syserr0r for correcting this typo!

jsh9 commented 1 year ago

Sending signal to you that this should get the magical label to silence the CHANGELOG entry check.

Hi @syserr0r , could you explain what this means? I implemented the CHANGELOG entry check in Github workflow, but I think it's a bit buggy, so I'm actually thinking about disabling them.

syserr0r commented 1 year ago

Sending signal to you that this should get the magical label to silence the CHANGELOG entry check.

Hi @syserr0r , could you explain what this means? I implemented the CHANGELOG entry check in Github workflow, but I think it's a bit buggy, so I'm actually thinking about disabling them.

It was in the placeholder text for the PR -- it said to send you the signal if it should get the magical label to silence the CHANGELOG entry check ¯\_(ツ)_/¯

The source is from here in your repo: https://github.com/jsh9/cercis/blob/main/.github/PULL_REQUEST_TEMPLATE.md?plain=1#L16-L17

jsh9 commented 1 year ago

Ah I see. I inherited this template from Black when I forked it, so I didn't immediately realize where it came from.