search

jsha / blocktogether

Share your blocks and subscribe to others'
GNU General Public License v3.0
330 stars 68 forks source link

Switch from Q.allSettled to Q.all #174

Closed jsha closed 9 years ago

jsha commented 9 years ago

Q.allSettled makes it easy to silently fail, because an Error in the array of Promises doesn't bubble up as an error in the returned Promise. Instead, the caller has to remember to map through the returned objects checking for errors, which is easy to forget (and which none of the callsites in Block Together do).

This caused this bug: https://github.com/jsha/blocktogether/issues/173

cc @binaryparadox @h0ke @doeg for code review.

techdubb commented 9 years ago

Looks good to me. :100:

jsha commented 9 years ago

Thanks!