search

jshackles / Enhanced_Steam

Enhances the Steam Experience
www.EnhancedSteam.com
GNU General Public License v3.0
1.32k stars 195 forks source link

Price regions #1243

Open M2us opened 7 years ago

M2us commented 7 years ago

Hi! I from Ukraine, but my steam account region is Russia, and my currency is RU. I go to settings and setted.... look here. https://pp.vk.me/c638821/v638821141/15d9f/LKabLSU6bSc.jpg

You make see, i setted to show me Ukraine region. But, i can't see this in steam. https://pp.vk.me/c638821/v638821141/15d27/t7qBc-0Z49I.jpg

Yes, now i'm in Ukraine, and maybe therefore plugin don't want show me my region? Can you fix this?

Sorry for my English. -.- xD

Rudokhvist commented 7 years ago

This bug is still present. If region of account is not the same as region from where you connect now - price of region from where you connect will not be shown anywhere. It's very inconvenient in travels.

JoiNNN commented 7 years ago

I'm in EU, and adding Ukraine shows regional prices just fine. What should I do to replicate this bug?

Rudokhvist commented 7 years ago

This issue is actually important only for those who travel outside of home region, so I'm unsure how to reproduce it. But I'll try to explain what effect cause this bug, and that effect you can see.

You are in EU, so you see EU price on the game page - the one you see even without ES. With ES you can add arbitrary regions to the extra dropdown box, but if you add EU region to this box - it won't be displayed. Let's say you added Ukraine region box - you will see EU price on page, and Ukraine in dropdown. And now let's say you decide to travel to Ukraine for vacation. You enter steam from Ukraine - you still have EU prices on game page, because your account is originated from EU. But because you are now in Ukraine - you won't see Ukraine prices in dropdown box! Instead you can actually add EU region and see it both in dropdown box and on game page.

So, my suggestion is simple - don't suppress showing of current region in dropdown box. This suppressing is actually a gray UI pattern, because ES behavior is different from what it's settings shows.

JoiNNN commented 7 years ago

OK thanks, I was able to replicate what you described with a small tweak to ES's code. First, the ISO code for Ukraine was wrong, I've submitted a fix for that already, and while that might've caused some issues with price conversions is not what actually caused the problem. (actually has nothing to do with currency)

ES deliberately avoids adding the current country/region the logic being that showing the same information twice is unnecessary, but that's not the case every time.

So unless @jshackles has a better idea I'd like to make it an option to force the addition of current region/country to the drop-down, or do some magic to detected whether the price shown on site and the one for current region/country are in fact similar, and if not add the country to the drop-down.

Rudokhvist commented 7 years ago

Thank you very much! I think I would just fork for now and remove this check, because I'm now in foreign country and actually suffer from this issue. When it will be resolved (one way or another) I'll just switch back to official version.

M2us commented 7 years ago

You are my hero! Thnx. ^__^

VanityFox commented 5 years ago

So, Enhanced Steam is discontinued. There is now Augmented Steam. Perhaps your requested feature/bugfix is already implemented there! If not, you could move your issue there.