search

jshackles / Enhanced_Steam

Enhances the Steam Experience
www.EnhancedSteam.com
GNU General Public License v3.0
1.32k stars 195 forks source link

One or more requests failed #1441

Open derFeef opened 6 years ago

derFeef commented 6 years ago

Might be linked to Steam Economy Enhancer- using latest Firefox build and Greasemoney SEE script. http://steamcommunity.com/market/

One or more requests failed:

    http://steamcommunity.com/market/priceoverview/?country=AT¤cy=3&appid=753&market_hash_name=362680-Itward (429: Too Many Requests)
    http://steamcommunity.com/market/priceoverview/?country=AT¤cy=3&appid=753&market_hash_name=362680-Itward (429: Too Many Requests)
    http://steamcommunity.com/market/priceoverview/?country=AT¤cy=3&appid=753&market_hash_name=355970-The%20Pond (429: Too Many Requests)
    http://steamcommunity.com/market/priceoverview/?country=AT¤cy=3&appid=753&market_hash_name=206210-Speedy%20%28Foil%29 (429: Too Many Requests)
RainOne commented 6 years ago

I also get an access denied when trying to look at my market transaction history. It seems that I have too many market transactions and the DDOS protection kicks in. Maybe add in a delay when requesting?

runer112 commented 6 years ago

I also have this issue. Searching past issues, this has been reported a couple times and has been correctly diagnosed as becoming temporarily blocked due to too many requests in a short period of time.

However, nobody has seemed to assert that this is Enhanced Steam's fault. I'd like to suggest that it is. Steam's rate limiting seems to have been around for long enough that it has effectively become part of its API (perhaps it's even explicit somewhere). By not respecting this limit, a client is breaking the API.

Glancing at enhancedsteam.js, it seems that most or all requests are made through http_get. This should be great news for ease of fixing this issue; not just in this specific case, but on a global level. The function could be augmented to examine the URL being requested and, for URL patterns that have known rate limiting applied, the requests can be queued with a client-side rate limit to keep under the API rate limit.

VanityFox commented 5 years ago

So, Enhanced Steam is discontinued. There is now Augmented Steam. Perhaps your requested feature/bugfix is already implemented there! If not, you could move your issue there.