search

jshackles / Enhanced_Steam

Enhances the Steam Experience
www.EnhancedSteam.com
GNU General Public License v3.0
1.31k stars 195 forks source link

IsThereAnyDeal seems to not work on wishlist when currency is changed #1442

Open nomadhook opened 7 years ago

nomadhook commented 7 years ago

I am living in South Africa and thus have changed the price checker to be in ZAR.

I have noticed that the price checking seems to use the correct currency when on a products page, however, from the wishlist all prices come up as $0 (which is not only the incorrect price but also the wrong currency). I have attached two images, the first is the bug from the wishlist, the second image is the price checking (with the same settings) from the game's store page.

The lowest price also seems to be incorrect as you can see the steam's price is lower that GOG's however ec thinks GOG has the best offer.

screenshot-2017-9-22 steam community nomadhook games

screenshot-2017-9-22 divinity original sin 2 on steam

FrantaM commented 7 years ago

https://github.com/jshackles/Enhanced_Steam/blob/4e47521b9e3aa83f10def12b795c80e1c89e8dff/enhancedsteam.js#L1803

enhancedsteam.js:1803 Uncaught TypeError: Cannot read property 'currency' of undefined
    at Object.<anonymous> (enhancedsteam.js:1803)
    at i (jQuery.min.js:2)
    at Object.add [as done] (jQuery.min.js:2)
    at Object.<anonymous> (enhancedsteam.js:1802)
    at i (jQuery.min.js:2)
    at Object.fireWith [as resolveWith] (jQuery.min.js:2)
    at y (jQuery.min.js:4)
    at XMLHttpRequest.c (jQuery.min.js:4)
VanityFox commented 5 years ago

So, Enhanced Steam is discontinued. There is now Augmented Steam. Perhaps your requested feature/bugfix is already implemented there! If not, you could move your issue there.