[Bug]? "Current Lowest Price" of trading cards in Badge page is not working for some currencies.

jshackles / Enhanced_Steam

Enhances the Steam Experience

www.EnhancedSteam.com

GNU General Public License v3.0

1.31k stars 195 forks source link

[Bug]? "Current Lowest Price" of trading cards in Badge page is not working for some currencies. #1510

Closed Z56B29A2 closed 6 years ago

Z56B29A2 commented 6 years ago

As stated in title. Not sure if it is a bug or just a function that haven't been enabled for some currencies.

The "Current Lowest Price" in Badge page always shows 0 no matter what the actual price is. This happened on HKD TWD and CNY, yet on USD GBP and EUR everything seems to work as intended.

I haven't test other currencies yet, so it could happened on other currencies too.

2017-12-16_214202

Cheers,

jshackles commented 6 years ago

The price conversion on this feature is done server-side presently but that is causing issues with the currencies and the fact that Valve is supporting over 30 currencies now. This feature needs to be re-written so that the value requested from the server is always in USD and the conversion happens client-side (since the client is already caching the conversion rate table anyway).

This should be fixed in the next release.

Z56B29A2 commented 6 years ago

@jshackles Good to know! Thanks for your quick reply and effort on this great project. (๑•̀ㅂ•́)و✧