jshackles / Enhanced_Steam

Enhances the Steam Experience
www.EnhancedSteam.com
GNU General Public License v3.0
1.32k stars 195 forks source link

"Add to Cart" button in wishlist can't add TV Seasons to the cart #1526

Open KarlCastle opened 6 years ago

KarlCastle commented 6 years ago

I have "Con Man" (Appid 549290) on my wishlist.

Clicking "Add to Cart" from the wishlist creates this error:

Uncaught TypeError: Cannot read property '0' of undefined
    at Object.<anonymous> (enhancedsteam.js:3163)

The relevant line is:

                deferred.resolve(app_data.data.packages[0]);

http://store.steampowered.com/api/appdetails/?appids=549290 doesn't have a "package" member. There are two bundles (1848 and 2159) associated with the appid and 27 individual titles (the episodes of the series). None of the ids are specified in the steam api response :S

{
"success":true,
"data":{
  "type":"series",
  "name":"Con Man",
  "steam_appid":549290,
  "required_age":0,
  "is_free":false,
  "controller_support":"full",
  "detailed_description": ...
  "about_the_game": ...
  "short_description": ...
  "fullgame":{"appid":null,"name":"Uninitialized"},
  "supported_languages": ...
  "header_image":"http://cdn.akamai.steamstatic.com/steam/apps/549290/header.jpg?t=1481317571",
  "website":null,
  "pc_requirements": ...
  "mac_requirements": ...
  "linux_requirements": ...
  "legal_notice":"©2015 Con Man Productions, LLC",
  "developers":["Lionsgate"],
  "publishers":[""],
  "package_groups":[],
  "platforms":{"windows":true,"mac":true,"linux":true},
  "categories": ...
  "genres":[{"id":"82","description":"Episodic"}],
  "screenshots": ...
  "movies": ...
  "release_date":{"coming_soon":false,"date":"9 Nov, 2016"},
  "support_info":{"url":"","email":""},
  "background":"http://cdn.akamai.steamstatic.com/steam/apps/549290/page_bg_generated_v6b.jpg?t=1481317571"
  }
}

This also seems to affect repositioning cards in the wishlist by renumbering as that also calls get_app_subid()

pka4916 commented 6 years ago

Sounds like my issue that I reported yesterday, but I didn't see any errors. Seems to have happened with the last update

VanityFox commented 4 years ago

So, Enhanced Steam is discontinued. There is now Augmented Steam. Perhaps your requested feature/bugfix is already implemented there! If not, you could move your issue there.