jshackles / Enhanced_Steam

Enhances the Steam Experience
www.EnhancedSteam.com
GNU General Public License v3.0
1.31k stars 195 forks source link

Images in "New Releases" list are broken when browsing in HTTPS. #1579

Open UnluckyNinja opened 6 years ago

UnluckyNinja commented 6 years ago

Steam store now supports full site HTTPS and will not redirect you back to HTTP anymore. (Both protocol are avaliable now.) However, I found things added by ES got some problems. The "New Releases" list on Steam homepage can't show images when in HTTPS, like this: image Original lists from steam work as usual.

More details: The broken image url from ES is like https://cdn.akamai.steamstatic.com/steam/apps/822140/capsule_184x69.jpg which Chrome will show NET::ERR_CERT_COMMON_NAME_INVALID error if you open it in new tab. The normal image url is like https://steamcdn-a.akamaihd.net/steam/apps/578080/capsule_184x69.jpg

Browser: Chrome 65. Location: China. Using official ES extension from Chrome web store.

Maybe we can infer the CDN domain from original urls?

ghost commented 6 years ago

Yup confirmed on my side too. 2018-04-27_151702

dubesor commented 6 years ago

yep, same issue. been that way for a while now, super annoying.

steamnew

Azamaru commented 6 years ago

You need to allow permissions in chrome://settings/content/siteDetails?site=https%3A%2F%2Fcdn.akamai.steamstatic.com default

ghost commented 6 years ago

Any specific permission that I need to set allow?

Azamaru commented 6 years ago

Don't know. I allow all posible permissions(open in new link, download etc.)

UnluckyNinja commented 6 years ago

@Azamaru The problem is that the site's SSL cert doesn't match their domain, so it's blocked by Chrome, instead of permission. BTW, I saw their fix commit (PR) on this problem in the repo (they changed the url to the valid one). So actually we don't have to do anything. Just wait for an update and it will be fine.

ghost commented 6 years ago

Thanks for that info Unlucky. Will wait for update. :)

Jagged commented 6 years ago

It seems the hostname for the images are incorrect. Example:

Broken: https://**cdn.akamai.steamstatic.com**/steam/apps/872240/capsule_184x69.jpg (url from New Releases tab)

Works: https://**steamcdn-a.akamaihd.net**/steam/apps/872240/capsule_184x69.jpg (url from Upcoming tab)

WORKAROUND:

First disable the HTTPS cert check used by the hostname for a blank placeholder gif file:

  1. Type https://store.akamai.steamstatic.com/public/images/blank.gif into the Chrome url bar.
  2. Click on "Advanced" down bottom-left when it complains that your connection is not private.
  3. Click on "Proceed to store.akamai.steamstatic.com (unsafe) image
  4. It should then show a blank page, being the blank image.

Repeat for the game images which use a different host:

  1. Type https://cdn.akamai.steamstatic.com/steam/apps/872240/capsule_184x69.jpg into the browser URL bar.
  2. Click on "Advanced" down bottom-left when it complains that your connection is not private.
  3. Click on "Proceed to cdn.akamai.steamstatic.com (unsafe)
  4. It should then show a game image. By unblocking this one it will have unblocked all of them that share the same hostname. image
VanityFox commented 5 years ago

So, Enhanced Steam is discontinued. There is now Augmented Steam. Perhaps your requested feature/bugfix is already implemented there! If not, you could move your issue there.