search

jshackles / Enhanced_Steam

Enhances the Steam Experience
www.EnhancedSteam.com
GNU General Public License v3.0
1.31k stars 195 forks source link

GruntJS #443

Open Smashman opened 10 years ago

Smashman commented 10 years ago

http://gruntjs.com/

Worth looking into for linting and minification?

Smashman commented 10 years ago

I also chucked enhancedsteam.js through http://jshint.com/

It's not pretty and I think we oughta go through it and give it a clean up.

jshackles commented 10 years ago

Yes I agree the code could be cleaned up quite a bit, though a lot of the errors given by jshint.com revolve around $ being an undefined variable, since it's not taking into account that jQuery is loaded before enhancedsteam.js.

Anyway, I'm all for minification of the code as part of the build process before it's sent to Google.

Smashman commented 10 years ago

It notes 52 warnings in only 16% of the file, of which the undefined variables do not count. That's pretty bad :-1:

sharkiller commented 10 years ago

grunt or gulp are very good. gulp have a lot of good plugins http://gulpjs.com/plugins/

Saturate commented 10 years ago

Gulp is pretty much worth it let alone for the JSHint feature. It also provides the ability to use some other nice things in the future.

I have worked with both gulp and grunt, and my choice would be gulp in this case.

I made a basic gulpfile that runs JSHint. #510

VanityFox commented 5 years ago

So, Enhanced Steam is discontinued. There is now Augmented Steam. Perhaps your requested feature/bugfix is already implemented there! If not, you could move your issue there.