search

jshackles / RetroGOG

RetroArch integrations for GOG Galaxy 2.0
92 stars 11 forks source link

After closing and restarting the client, games are no longer "Installed" until disconnecting and reconnecting the integrations #10

Open instinctualjealousy opened 3 years ago

instinctualjealousy commented 3 years ago

And of course, trying to "install" them isn't something you can do, so it just shows as "Not Compatible". Latest GOG Galaxy 2.0 as of writing. Using most built-in integrations alongside. However GOG is querying the presence of a game isn't working for restarts, just clean connections. Considering how damning it is, vs. how it's never been reported EVER, I'm curious if it's a very recent bug or if I did some sort of user error dumb. :( I'm not having this issue with other integrations.

Pab10Suarez commented 3 years ago

hey bro i was about to repor the same issue i thnk it's a problem with the new update image not sure what but to temporary fix this i have to reconnect integrations but when i start gog galaxy again still broken this is the only thing i found :c for now

instinctualjealousy commented 3 years ago

Here's what's weird, I left my GOG stay open for a bit (had Thanksgiving dinner actually) and games now are showing "Play". Is it just taking a good while?

Pab10Suarez commented 3 years ago

Here's what's weird, I left my GOG stay open for a bit (had Thanksgiving dinner actually) and games now are showing "Play". Is it just taking a good while?

lol same for me i'm going to restart gog galaxy to see if now it's solved or it's like you said already restarted gog galaxy and yeah now take a while, strange, probably this changed something important image

DemiMelfice commented 3 years ago

I've had the exact same problem. For the longest time I refused to add SNES and Genesis to GOG with this plugin just due to the large amount of games and how it always crashed GOG when it was added or launching GOG with it added.

I added PS1, N64 ect maybe 6-7 months ago and all of them show "Play" in games but only the last few weeks I attempted to add Genesis and SNES and they pull the game library from RetroArch but don't have "Play" just "Install"....

DemiMelfice commented 3 years ago

Ok follow up on this, it looks like I now have the problem across all integrations, they all show "Install" instead of "Play".

wolfeng-db commented 3 years ago

Is this beautiful plugin not being worked on anymore? The issue is still around and game time is also not being tracked even if you do get the games to launch.

chuckzee commented 3 years ago

@jshackles any insight into this issue? I know it's a side project but I'm wondering if you are aware if it's a GOG api issue or something that just requires dev time?

jshackles commented 3 years ago

@chuckzee I believe this happens when the local Galaxy games database gets out of sync with what GOG has recorded on their servers. The more games you have integrated, the higher the probability is of this happening. I'll have to look at some other plugins to see if and how they might be handling this situation. Unfortunately the only known fix at this time is to disconnect and reconnect the integrations.

chuckzee commented 3 years ago

@jshackles I'll take a peek at some error logs in gog galaxy if I can. Maybe something helpful.

chuckzee commented 3 years ago

@jshackles 

2021-01-26 19:54:46,501 - root - DEBUG - Task manager plugin internal: creating task 1 (shutdown)
2021-01-26 19:54:46,501 - root - ERROR - Task manager plugin internal: exception raised in task 1 (shutdown)
Traceback (most recent call last):
  File "C:\Users\chuck\AppData\Local\GOG.com\Galaxy\plugins\installed\segag_e3ac94e7-945e-459d-bc1e-676cff8173f9\galaxy\task_manager.py", line 17, in task_wrapper
    result = await coro
TypeError: object NoneType can't be used in 'await' expression

TypeError coming from the plugin itself looks like.

chuckzee commented 3 years ago

Seeing a lot of this too:


2021-01-26 19:51:06,081 - root - INFO - Sending notification: method=game_time_import_success, params={'game_time': GameTime(game_id='Ys III', time_played=0, last_played_time=None)}
2021-01-26 19:51:06,081 - root - DEBUG - Sending 123 byte of data
2021-01-26 19:51:06,081 - root - DEBUG - Task manager notification client: creating task 751 (drain)
2021-01-26 19:51:06,081 - root - DEBUG - Task manager jsonrpc server: finished task 24 (drain)
2021-01-26 19:51:06,081 - root - DEBUG - Sending data: {"jsonrpc": "2.0", "id": "13", "error": {"code": 600, "message": "Import already in progress"}}
Pab10Suarez commented 3 years ago

@chuckzee I believe this happens when the local Galaxy games database gets out of sync with what GOG has recorded on their servers. The more games you have integrated, the higher the probability is of this happening. I'll have to look at some other plugins to see if and how they might be handling this situation. Unfortunately the only known fix at this time is to disconnect and reconnect the integrations.

i've found more information in ps2 plug in ( https://github.com/AHCoder/galaxy-integration-ps2/issues/27#issuecomment-772276700 ) also i've tested and it takes like one hour to games to appear as installed, this happens with more emulator plug ins but this solution could help?

Pab10Suarez commented 3 years ago

update about what i think is causing it gogcom/galaxy-integrations-python-api#180 (comment)

Pab10Suarez commented 3 years ago

At least for me, this bug is fixed