search

jshackles / idle_master

Get your Steam Trading Cards the Easy Way
GNU General Public License v2.0
1.54k stars 560 forks source link

portable version is not portable #178

Open reznoa opened 8 years ago

reznoa commented 8 years ago

it create and use user.config file on subdir of My Documents. so i have to handle it, too. i think it's not portable feature.

exmex commented 8 years ago

It's because IdleMaster uses Properties.Default.Settings. So it's located under: %userprofile%\appdata\local\IdleMaster\IdleMaster.exe_Url_RANDOMNUMBERSANDLETTERS\1.3.0.0 or %userprofile%\Local Settings\Application Data\IdleMaster.exe_Url_RANDOMNUMBERSANDLETTERS\1.3.0.0

depending on the windows version.

q00u commented 8 years ago

Definitely an anti-portable situation. "user.config" should be read/stored in the current directory, not buried in appdata.

exmex commented 8 years ago

I was just trying to make it clear why and where the config file is.

NotTsunami commented 8 years ago

Should be closed by #205 if the code is correct and jshackles merges

richardfrost commented 8 years ago

@Tsunamical Was there any discussion on your PR (#205)? I saw that you closed it back in April, but didn't see any discussion. I too would like to see the config file saved in the applications directory.

drepark commented 8 years ago

I cant recieve any cards in team fortress are the cards like a weapon or something?

On Jun 9, 2016 8:47 PM, "Richard Frost" notifications@github.com wrote:

@Tsunamical Was there any discussion on your PR (#205)? I saw that you closed it back in April, but didn't see any discussion. I too would like to see the config file saved in the applications directory.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

richardfrost commented 8 years ago

This issue is probably not the best place for this question @drepark, but Idle Master is used to get Steam Trading Cards. If you look at your "Badges" page in steam you can see the list of games you are eligible to receive card drops in (and the ones you are not). Team Fortress 2 is a Free to Play (F2P) game, and therefore requires you to have either bought it before it was free, or to spend money in the online store to "earn" card drops.

drepark commented 8 years ago

How about csgo what card drops is it.Is it like skins or something or knives On Jun 9, 2016 8:57 PM, "Richard Frost" notifications@github.com wrote:

This issue is probably not the best place for this question @drepark https://github.com/drepark, but Idle Master is used to get Steam Trading Cards. If you look at your "Badges" page in steam you can see the list of games you are eligible to receive card drops in (and the ones you are not). Team Fortress 2 is a Free to Play (F2P) game, and therefore requires you to have either bought it before it was free, or to spend money in the online store to "earn" card drops.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jshackles/idle_master/issues/178#issuecomment-224886198, or mute the thread https://github.com/notifications/unsubscribe/ARr6trkpG9t3XfRF2TiWM_Znw6mAHfS-ks5qKA2rgaJpZM4GS8sC .

NotTsunami commented 8 years ago

@richardfrost Turns out that code snippet was not actually correct. I found it on a stackexchange post and automatically assumed it was correct but such function does not exist. There are other hacky methods to do it, it's just a pain. I'll see if I can't write something less-hacky, although most development on idle_master is dead, hence why I closed my other PRs as well.

richardfrost commented 8 years ago

@Tsunamical That makes sense, thanks for sharing your reasons. Personally I have been very happy with Idle Master in its current state, aside from this portable config file, which is not a show stopper. It looks like there are plenty of forks, so but if jshackles is done with this project maybe someone else can keep it going. Its an awesome project!