jshackles / idle_master

Get your Steam Trading Cards the Easy Way
GNU General Public License v2.0
1.54k stars 560 forks source link

Badge page didn't load #241

Open Tujurikkuja opened 7 years ago

Tujurikkuja commented 7 years ago

There seems to be an error while loading the badges page.

This is in the error log:

04.01.2017 10:16.28 CookieClient -> GetHttpAsync, for url = http://steamcommunity.com/profiles//badges/?p=1 System.Net.WebException: An exception occurred during a WebClient request. ---> System.NullReferenceException: Object reference not set to an instance of an object. at System.Net.WebClient.DownloadBitsState.SetResponse(WebResponse response) at System.Net.WebClient.DownloadBitsResponseCallback(IAsyncResult result) --- End of inner exception stack trace --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult() at IdleMaster.CookieClient.d__5.MoveNext()

I tried opening the URL in the browser and it works so it seems like something is broken in the successful load handle.

Would greatly appreciate a fix for that. Big time fan :)

goto1134 commented 7 years ago

same problem here

Tujurikkuja commented 7 years ago

But it seems like the owner has abandoned the project so I guess there's no hope for a fix. Unless someone forks it and takes over the development/maintenance.

goto1134 commented 7 years ago

Fixed by #197

Tujurikkuja commented 7 years ago

Do I really have to open this in VS? Is there a simpler way to modify the Setup so that it would load the binaries from the fixed fork?

goto1134 commented 7 years ago

@Tujurikkuja no, but you can get it from my dropbox fixed. https://www.dropbox.com/s/uk08zao9giwqq5m/idle_master.zip?dl=0

Tujurikkuja commented 7 years ago

Already loaded another branch from user treloret. His fix seemed more reasonable (not looping over all the cookies).

goto1134 commented 7 years ago

@Tujurikkuja link it here please

Tujurikkuja commented 7 years ago

https://github.com/jshackles/idle_master/pull/243

opello commented 7 years ago

I don't think iterating the collection twice (once for each item lookup) is more reasonable.