jshemas / openGraphScraper

Node.js scraper service for Open Graph Info and More!
MIT License
643 stars 102 forks source link

6.5.0 update error #215

Closed woohyun1031 closed 3 months ago

woohyun1031 commented 4 months ago

Describe the bug

Hi. I always use this library successfully. Thank you!

"After upgrading open-graph-scraper from version 6.3.2 to 6.5.0 in the current Next.js 14 project, a compilation error occurred during the build. This issue was observed on both client and server components. While tracing the error, it was identified that the problem originated in the 'lib/web/fetch/util.js' file, and it was noted that undici, a dependency of open-graph-scraper, was also updated. Testing with another Next.js project revealed that the error started occurring from a specific version of open-graph-scraper onwards. As a result, I downgraded back to the previously used version 6.3.2. I'm having difficulty pinpointing the exact cause of this error, and I'm curious if you have any insights into why it might be happening.

Screenshots 스크린샷 2024-03-05 오후 1 04 41

Environment

jshemas commented 4 months ago

I don't see any errors when I build my master(6.5.0) branch using node v20.10.0. Can you make a example repo that has the problem?

giyeol commented 4 months ago

I have the same problem, and using version v20.11.1.

giyeol commented 4 months ago

I have similar problem, and using version v20.11.1.

./node_modules/.pnpm/undici@6.7.0/node_modules/undici/lib/web/fetch/util.js
Module parse failed: Unexpected token (608:63)
|             // 5. If object is not a default iterator object for interface,
|             //    then throw a TypeError.
>             if (typeof this !== "object" || this === null || !(#target in this)) {
|                 throw new TypeError(`'next' called on an object that does not implement interface ${name} Iterator.`);
|             }
giyeol commented 4 months ago

I have the same problem, and using version v20.11.1.

It's probably an issue with the undici package. I fixed it with the following modification.

// package.json
  "pnpm": {
    "overrides": {
      "open-graph-scraper>undici": "6.6.2"
    }
  }
jshemas commented 4 months ago

@giyeol @woohyun1031 it looks like that line was last changed in https://github.com/nodejs/undici/pull/2743, which was part of undici@6.7.0. I would recommend opening a issue/pull request with undici. I'm still not able to reproduce the problem.

nicolad commented 3 months ago

having the same error

image
jshemas commented 3 months ago

It looks like the undici team is aware of the issue -> https://github.com/nodejs/undici/issues/2954 and are pushing to fix this in nextjs. Closing this for now since there isn't a way this can be fixed in OGS, please follow up with the nextjs team.