search

jshemas / openGraphScraper

Node.js scraper service for Open Graph Info and More!
MIT License
643 stars 102 forks source link

Follow manifest for favicon #221

Closed psugihara closed 3 weeks ago

psugihara commented 1 month ago

Is your feature request related to a problem? Please describe. I'm scraping favicons for company websites. This works pretty well with openGraphScraper but I found an edge case that is not handled.

Here's the example site where the favicon is not found but my browser finds it from the manifest: https://shop.mercaso.com

Describe the solution you'd like Get favicon from web manifest if it can't be found otherwise.

Describe alternatives you've considered I could use parse-favicon, but I like the OG image fallbacks this package provides.

Additional context

Screenshot 2024-06-02 at 3 26 43 PM
jshemas commented 1 month ago

Hello. open-graph-scraper@6.5.2 should fix this use case. Let me know if I need to add anymore fall backs.

jshemas commented 3 weeks ago

Closing this for now, let me know if you have any more issues.

psugihara commented 3 weeks ago

cool. appreciate the quick fix!