Closed Sydney-o9 closed 4 weeks ago
That was added fix ESM imports for module/moduleResolution = NodeNext
projects. I'm not sure if there is a better way to fix that problem.
Hello. This should be fixed in open-graph-scraper@6.7.1
Hello. This should be fixed in
open-graph-scraper@6.7.1
Hello, the types SuccessResult
and ErrorResult
are not exported in 6.7.1
@nekochan0122 These types were moved into the types
file. So you can do something like import type { SuccessResult, ErrorResult } from 'open-graph-scraper/types/lib/types';
@jshemas Thx for the reply, but I still got the errors.
import type { SuccessResult, ErrorResult } from 'open-graph-scraper/types/lib/types';
should now work in open-graph-scraper@6.7.2
Will be more nice if the import path can be shorter :
import type { SuccessResult, ErrorResult } from 'open-graph-scraper/types
By changing:
"./types/lib/types": "./types/lib/types.d.ts"
to:
"./types": "./types/lib/types.d.ts"
@nekochan0122 Good idea. Changes are live in open-graph-scraper@6.8.0
. Open a new issue if you have any more problems.
Describe the bug There is a regression in
^6.6
for Tyepscript users.We had to downgrade to![image](https://github.com/user-attachments/assets/e1f580b8-1934-4c42-9fae-d62d5543ec0b)
^6.5
to transpile properlyTo Reproduce
Use
^6.6
and build$ tsc
Expected behavior It should compile
Actual behavior It doesn't compile with error:
MacOS
v18.20.1
^6.6
and^6.7