search

jshemas / openGraphScraper

Node.js scraper service for Open Graph Info and More!
MIT License
669 stars 105 forks source link

feature: add onlyGetOpenGraphInfo image option #240

Closed SimonSiefke closed 1 month ago

SimonSiefke commented 2 months ago

fixes #238

With onlyGetOpenGraphInfo: image, lots of data is returned for title and description and the image would always be accurate (e.g. not a random icon which currently could happen in some edge cases).

jshemas commented 2 months ago

Hello. Thanks for the PR! Should options.onlyGetOpenGraphInfo be a boolean | array of fall backs to not use?

SimonSiefke commented 2 months ago

Thanks for the feedback! I changed the code to use an array or boolean.

jshemas commented 2 months ago

@SimonSiefke This looks good! Can you fix the eslint errors and update the readme?

jshemas commented 1 month ago

Thanks for the PR! The tests are failing for a unrelated reason.

jshemas commented 1 month ago

changes are live in open-graph-scraper@6.8.0