search

jshimko / meteor-launchpad

A base Docker image for Meteor applications.
https://hub.docker.com/r/jshimko/meteor-launchpad/
MIT License
276 stars 152 forks source link

meteor 1.8 support #122

Open sebastianlutter opened 6 years ago

sebastianlutter commented 6 years ago

Hi,

the current version does not support meteor 1.8. I got into trouble when I used npm bcrypt 3.0.2 with meteor-launchpad-2.3.0, binary API is incompatible with bcrypt shared object (lazy loading error).

With nodejs and mongo version updated everything is fine again. I also switched to debian stretch, and installed gosu from debian package (1.10 as the one you installed manually before)

Merge my changes if you like, and maybe release a new version 2.3.1 of your meteor launchpad so I do not need to use my own docker image :)

jshimko commented 6 years ago

Hey @sebastianlutter, thanks for the work here! However, I can't merge this as it is right now because you've deleted several scripts and the entire CI build directory. I realize that's probably for your own builds of your repo, but that stuff is how the automated releases happen in this repo. If you can revert those changes, I'd be happy to get your Meteor-related updates merged.

Related... once I find the free time, I'm going to do a complete rewrite of this project to be more flexible with build caching and Meteor/Node versions. For as long as this project has existed, the latest release only tends to support a few versions of Meteor before things break. I'd like to change that so it isn't such an ongoing maintenance burden for everyone.

But first, I'll settle for just getting things working with the latest version of Meteor. :)

sebastianlutter commented 6 years ago

Hi Jeremy, I thought a pull request just contains the commits at the time I created it. The commits of interest are the first four (cbe14fe, 65fd7df , 4c6dff9, 025329d ).

I'll revert the other commits so you can easily merge it, I just needed them for my own builds.

sebastianlutter commented 6 years ago

Now only the meteor 1.8 relevant changes are part of my master. I added my email into Dockerfiles MAINTAINER, keep or remove it as you like. Looking forward for a v2.3.1 release :)

Once I find free time . . . I know this very well ;) If you start your rewrite feel free to drop me a line, depending on my workload I'm willing to help

best Sebastian

gustawdaniel commented 4 years ago

Now I am using meteor 1.9 with this package so this pull request seems to outdated. I propose merge or close it.