search

jshimko / meteor-launchpad

A base Docker image for Meteor applications.
https://hub.docker.com/r/jshimko/meteor-launchpad/
MIT License
276 stars 152 forks source link

Custom docker image names not using correct base image #43

Closed krismeister closed 7 years ago

krismeister commented 7 years ago

Per the instructions:

# or specify a custom image name
./build.sh myorg/myimage

Does not respect the docker base images inside of dev.dockerfile and prod.dockerfile.

https://github.com/krismeister/meteor-launchpad/blob/master/dev.dockerfile#L1 https://github.com/krismeister/meteor-launchpad/blob/master/prod.dockerfile#L1

Expected result: prod.dockerfile & dev.dockerfile uses the new custom base image myorg/myimage:base

ps: this was a very tricky issue to find, I built many times before understanding what was happening.

jshimko commented 7 years ago

The v2 release has done away with the base image and now uses to two totally separate Dockerfiles for the two builds, so this should be all set now.

Thanks for filing the issue!

jshimko commented 7 years ago

Also, since there's no base image to build first, you can just run this now...

docker built -t whatever/you:want .
krismeister commented 7 years ago

thanks!