search

jshimko / meteor-launchpad

A base Docker image for Meteor applications.
https://hub.docker.com/r/jshimko/meteor-launchpad/
MIT License
276 stars 152 forks source link

Add --unsafe-perm to meteor build #8

Closed Jank1310 closed 7 years ago

Jank1310 commented 7 years ago

Meteor build (1.4.2) fails with this message:

You are attempting to run Meteor as the "root" user. If you are developing, this is almost certainly not what you want to do and will likely result in incorrect file permissions. However, if you are running this in a build process (CI, etc.) or you are absolutely sure you know what you are doing, add the --unsafe-perm flag to this command to proceed.

So the --unsafe-perm flag should probably be added to the build command too.

jshimko commented 7 years ago

Yep. Just discovered the same thing after the 1.4.2 update. Working on it right now. I'd prefer not to do --unsafe-perm though. The general best practice there is to use a non-root user to install Meteor and build the app. So that's what I'm working on. :)

Fix coming shortly...

jshimko commented 7 years ago

This PR is no longer needed, so I'm going to close it. All npm commands and starting the app are now done by a non-root user. Pull the latest build and give it try.

Thanks for taking the time to make the contribution @Jank1310!