search

jshimko / telescope-plugin-hero

A plugin to add a customizable hero banner to your Telescope site.
15 stars 3 forks source link

Hero Header doesn't look good #1

Closed x5engine closed 9 years ago

x5engine commented 9 years ago

Hi thank you for this great plugin,

I saw the demo and it's awesome, but i couldn't get this same result on my localhost

This is how it look like screenshot 2015-05-16 02 34 13

Thanks in advance

jshimko commented 9 years ago

What browser/OS are you using? Are you using the latest version of Telescope (devel branch)?

jshimko commented 9 years ago

That looks like tons of CSS conflicts to me.

x5engine commented 9 years ago

Yes this is just some css conflicts but everything is working good I'm using the latest Chrome version

jshimko commented 9 years ago

That's actually A LOT of conflicts. Just about every part of the plugin UI is pretty jacked up. :)

That's supposed to look like this:

hero-plugin

Do you have a bunch of other CSS with .hero or .hero-config classes? Unfortunately, there's not much I can do to fix CSS conflicts for everyone (other than trying to pick reasonably unique class names that are specific to the plugin). Perhaps you can change your .hero classes to something else?

You can see all of the plugin styles here or in the default content that should be in the custom CSS field in the config window.

jshimko commented 9 years ago

Actually, that looks like none of the styles in the plugin stylesheet are loaded. Just the ones in the config window seem to be doing something. Are you on Windows? I think I remember hearing that the fourseven:scss package had issues on Windows. That might be what's going on.

x5engine commented 9 years ago

yes i'm on windows and trying to inspect the styles right now

x5engine commented 9 years ago

none of the styles are loaded as you said

x5engine commented 9 years ago

Shouldn't the css file be inside client/scss folder ?

x5engine commented 9 years ago

i found the error it's Uncaught TypeError: Template.hero_layout.replaces is not a function 2

jshimko commented 9 years ago

That function runs fine for me in a default Telescope install. How did you install Telescope? Git clone or Atmosphere?

x5engine commented 9 years ago

downloaded the devel repo unziped then meteor that's all though i don't have the last 5 days commits

jshimko commented 9 years ago

Just pushed some changes. Try a meteor update and give it another test.

x5engine commented 9 years ago

ok i just tested it and it showed a little change, let me try it with a new fresh install

x5engine commented 9 years ago

Still same issue, the css isn't fully loaded

I tried it on a new devel install screenshot 2015-05-16 03 44 14

jshimko commented 9 years ago

Hmm. Not sure what to say. I can't reproduce your issue.

Can you confirm whether you have fourseven:scss installed? If not, can you try installing it manually?

x5engine commented 9 years ago

in .versions i have fourseven:scss@2.1.1 but i'm also sure about this. just flag it as unconfirmed. thanks

jshimko commented 9 years ago

How about if you force it to fourseven:scss@3.0.0? (You can to that in the telescope:lib package right here)

jshimko commented 9 years ago

Nevermind. That version is apparently broken on Windows too. See here: https://github.com/fourseven/meteor-scss/issues/83

It looks like you're probably going to have to wait until node-sass bugs are worked out for Windows users. Sorry.

Since this issue isn't related to my plugin, I'm closing it for now. Let me know if you run into any other issues. Thanks!

x5engine commented 9 years ago

I already have a 'fourseven:scss@2.1.1', package loaded from there

yes i'm sure it's from your plugin, i'll wait untill they fix it. Thanks