jshint / jshint.github.io

The homepage for JSHint
http://jshint.com
20 stars 19 forks source link

Favicon #48

Open pmaxhogan opened 7 years ago

pmaxhogan commented 7 years ago

This is a patch for a favicon.

jugglinmike commented 7 years ago

Thanks for the patch! Unfortunately, it's formatted incorrectly, so we can't accept it as-is. I can offer you some help to fix it, though.

You'll want to start by making sure you have checked out the latest version of the dev branch. Be sure that there are no additional commits "on top" of that (use git log to check) and that there are no new "unstaged" local changes (use git status to check).

The tricky part here is that we need to deploy this file to the root of the site's public file hierarchy, but the current build system isn't really set up for such an operation. If you place the file in the res/ directory, I would accept a quick-and-dirty alteration to the project Makefile that copied it into place at deploy time.

Finally, your pull request should target the dev branch. We'll take care of updating the master branch the next time we deploy the site.

It's a bit convoluted, to be sure. Does my explanation make sense to you?