Closed youthlin closed 1 year ago
Hi @youthlin, thanks for your PR! I will need some time to review this, you may need some patience.
I have to admit I'm a bit ~weary~ wary about adding Chinese docs, mainly because I have no way to maintain them myself. I will probably merge them, but please add a warning disclaimer to make it clear that the chinese docs are not actively maintained/that they may diverge from the package version.
Hi @youthlin, thanks for your PR! I will need some time to review this, you may need some patience.
I have to admit I'm a bit weary about adding Chinese docs, mainly because I have no way to maintain them myself. I will probably merge them, but please add a warning disclaimer to make it clear that the chinese docs are not actively maintained/that they may diverge from the package version.
Thanks for your reply! I have added a translation notes on docs, please help review. I would watch this repo, and can synchronize the Chinese translation regularly.
@lzurbriggen Hi, can those code to be merged? What should I do more to help
@lzurbriggen Hi, can those code to be merged? What should I do more to help
Hi @youthlin!
@lzurbriggen is back in tomorrow. I guess he will get back to you as soon as he can.
@youthlin I don't really have the time to review this in detail, but it looks good in general. I'll merge this and create a pre-release. I may make some changes before I create a final release.
test
npm run test
passed.what changed and why
lang
, so I can use<Demo lang='zh_CN'/>
in docs/zh/demo.mdglobalProperties
jsExtractorOpts
jsExtractorOpts
to extract the custom keywordsjsExtractorOpts
to GettextConfigmsginit
msginit
can access theGETTEXTCLDRDIR
variableGetTextOptions
,GettextConfig