jshmrtn / vue3-gettext

Translate Vue 3 applications with gettext.
https://jshmrtn.github.io/vue3-gettext/
MIT License
70 stars 24 forks source link

Add custom keywords, and Chinese translation #35

Closed youthlin closed 1 year ago

youthlin commented 1 year ago

test

what changed and why

youthlin commented 1 year ago

fix https://github.com/jshmrtn/vue3-gettext/issues/20

lzurbriggen commented 1 year ago

Hi @youthlin, thanks for your PR! I will need some time to review this, you may need some patience.

I have to admit I'm a bit ~weary~ wary about adding Chinese docs, mainly because I have no way to maintain them myself. I will probably merge them, but please add a warning disclaimer to make it clear that the chinese docs are not actively maintained/that they may diverge from the package version.

youthlin commented 1 year ago

Hi @youthlin, thanks for your PR! I will need some time to review this, you may need some patience.

I have to admit I'm a bit weary about adding Chinese docs, mainly because I have no way to maintain them myself. I will probably merge them, but please add a warning disclaimer to make it clear that the chinese docs are not actively maintained/that they may diverge from the package version.

Thanks for your reply! I have added a translation notes on docs, please help review. I would watch this repo, and can synchronize the Chinese translation regularly.

youthlin commented 1 year ago

@lzurbriggen Hi, can those code to be merged? What should I do more to help

jeremyzahner commented 1 year ago

@lzurbriggen Hi, can those code to be merged? What should I do more to help

Hi @youthlin!

@lzurbriggen is back in tomorrow. I guess he will get back to you as soon as he can.

lzurbriggen commented 1 year ago

@youthlin I don't really have the time to review this in detail, but it looks good in general. I'll merge this and create a pre-release. I may make some changes before I create a final release.