search

jshoyos / soen390-team01

MIT License
0 stars 0 forks source link

Refactor reports code #115

Closed shahidakhan closed 3 years ago

shahidakhan commented 3 years ago

Refactored the code for the reports feature to call one function instead of multiple ones.

shahidakhan commented 3 years ago

Yeah just one column in one report does not take the value which we want, and its because the +- buttons in the inventory table, which is an input tag, so its tricky to fix. No, it does not seem to be complicated but its kinda tricky. Thats the reason i made a separate PR for the refactoring which was an easy fix.

t-andrews commented 3 years ago

Yeah just one column in one report does not take the value which we want, and its because the +- buttons in the inventory table, which is an input tag, so its tricky to fix. No, it does not seem to be complicated but its kinda tricky. Thats the reason i made a separate PR for the refactoring which was an easy fix.

@ShahidAKhan Could you still do it here? I don't think this is a blocker for another feature?

shahidakhan commented 3 years ago

Yeah just one column in one report does not take the value which we want, and its because the +- buttons in the inventory table, which is an input tag, so its tricky to fix. No, it does not seem to be complicated but its kinda tricky. Thats the reason i made a separate PR for the refactoring which was an easy fix.

@ShahidAKhan Could you still do it here? I don't think this is a blocker for another feature?

Yes yes I’ll do it and no i don’t think anything else depends on this.