search

jshrake / glsl-include

A Rust library for expanding #include directives in GLSL source strings
Apache License 2.0
4 stars 2 forks source link

Make Context::expand return Cow 🐄 #38

Open germangb opened 5 years ago

germangb commented 5 years ago

I think it would make sense for Context::expand to take in a slice &'a str and return a Cow<'a, str> to remove extra allocations when the glsl input has no includes.

Would you accept a PR?

jshrake commented 5 years ago

That sounds like a good idea.

Would you accept a PR?

Absolutely!

germangb commented 5 years ago

I'm taking a stab at #1. I might submit one for that one first before this one (If you're not on it already).

jshrake commented 5 years ago

Not a problem. I'm not actively working on this project (but I do make active use of it in https://github.com/jshrake/grimoire) so feel free to work on any open issue. I'm happy to help land any PRs.