search

jshreyans / frontend-101

Front-end winter assignment for Department of Visual Media. These include tasks based on Vanilla JS and CSS.
0 stars 1 forks source link

B10 Review #17

Open jshreyans opened 5 years ago

jshreyans commented 5 years ago

I hadn't seen the additional instructions page in the assignment folder. Saw this task and thought it was interesting so I did it first. Hope there's no bug!

sarthak-sehgal commented 5 years ago

Looks great! I think you're yet to try out the other methods though.

You also might want to add a "Not found" message for the non existent usernames.

jshreyans commented 5 years ago

Yes I've been working on them and will try to add both by tomorrow. And I'll also work on the 'Not Found' message. Thanks a lot!

jshreyans commented 5 years ago

@sarthak-sehgal I've added the remaining 2 methods along with error handling code. Pls check now.