search

jshreyans / frontend-101

Front-end winter assignment for Department of Visual Media. These include tasks based on Vanilla JS and CSS.
0 stars 1 forks source link

B9 Review #19

Closed jshreyans closed 5 years ago

jshreyans commented 5 years ago

Sure took a lot of reading up!

sarthak-sehgal commented 5 years ago

Your gh-pages branch doesn't seem to be updated.

PS: You can host the master branch with GitHub pages instead of maintaining two separate branches.

jshreyans commented 5 years ago

I've added the folder to gh-pages. Thanks for the input. I'll surely look into it.

sarthak-sehgal commented 5 years ago

Doesn't seem to work for me. @kunal-mohta @LakshSingla please verify.

kunal-mohta commented 5 years ago

It's working for me. @sarthak-sehgal The urls are too sensitive. If you miss www, it won't work. I suggest copying them from the code. @jshreyans551 Great job! It was one of the aims of this task to have you learn a new technology on your own from reading documentations.

jshreyans commented 5 years ago

Thanks a lot!