search

jshreyans / frontend-101

Front-end winter assignment for Department of Visual Media. These include tasks based on Vanilla JS and CSS.
0 stars 1 forks source link

Should use 45deg #3

Closed kunal-mohta closed 5 years ago

kunal-mohta commented 5 years ago

https://github.com/jshreyans551/frontend-101/blob/d0eb587a43ef89f78572217f6b370a3622ec1375/A/4.html#L143-L144

For #2 It looks and works fine, but when working with other developers, it can be really cryptic. This might seem small, but it becomes significant when professionals see your code (e.g. GSoC mentors). Try to achieve the same effect with the rotation being 45deg

Good work on the task other than this!

jshreyans commented 5 years ago

I'll do the necessary changes Thanks a lot!

kunal-mohta commented 5 years ago

You shouldn't close an issue before getting it reviewed by the person who opened it. :stuck_out_tongue_closed_eyes: Such little habits will help you get an upper hand over other developers. :wink:

kunal-mohta commented 5 years ago

I saw the latest commit, although the rotation now is 45deg, the cross doesn't look perfect. You need to keep the appearance perfect and use 45deg.

jshreyans commented 5 years ago

But I didn't close the issue. Does it close once you commit something referencing the issue? Yeah I'll look into it again

kunal-mohta commented 5 years ago

https://help.github.com/articles/closing-issues-using-keywords/

Cool discovery!! :stuck_out_tongue_winking_eye: Only these trigger words do.

jshreyans commented 5 years ago

Niiice XD So I tried correcting it by changing the transform-origin. Is that the correct way? I don't know if it looks right still.

kunal-mohta commented 5 years ago

I think simply increasing the width would do.

jshreyans commented 5 years ago

Yeah that works. Looks better now.