B2 Review - Githubissues

jshreyans commented 5 years ago

Completed B2(Clock) with JS setInterval() function and Date() object

LakshSingla commented 5 years ago

hourHand.style.transform = "rotateZ(" + hours + "deg)"; Although template strings are a part of ES6 syntax and we do not encourage using it during the fest sites unless it is transpiled (due to compatibility issues with older browsers), but you must know about it and how much cleaner looking code it produces. For assignment though, using ES6 is encouraged as we all have modern browsers.
line 72-74 Although the code performs well, but it is not readable enough. It may cause trouble when working in a team and other person would wanna make edits to your code. You can make it more readable by adding comments or naming the constants in your code

Apart from these, the logic part of the code is well written :tada: :tada:.

jshreyans commented 5 years ago

Yeah I got what you mean. And I'll add comments for line 72. Thanks.

kunal-mohta commented 5 years ago

@LakshSingla This seams fine now?

LakshSingla commented 5 years ago

@kunal-mohta Yep :+1:

jshreyans / frontend-101