search

jshttp / accepts

Higher-level content negotiation
MIT License
252 stars 42 forks source link

build: add type definitions #26

Open herrmannplatz opened 1 year ago

pke commented 9 months ago

Isn't that already covered by @types/accepts?

UlisesGascon commented 4 months ago

I agree with @pke, seems like https://www.npmjs.com/package/@types/accepts is covering this gap.

UlisesGascon commented 4 months ago

Based on https://github.com/expressjs/discussions/issues/192 seems like the current approach is to let types outside of the repositories.

carpasse commented 3 months ago

@UlisesGascon should we close this PR then?

carpasse commented 3 months ago

Apologies I closed the PR by mistake when trying to comment 🤦🏻‍♂️