Replace deep-equal with dequal - Githubissues

jshttp / accepts

Higher-level content negotiation

MIT License

252 stars 42 forks source link

Replace deep-equal with dequal #33

Open wojtekmaj opened 1 month ago

wojtekmaj commented 1 month ago

This PR replaces deep-equal with dequal, an alternative package with 0 dependencies (as opposed to 49: https://npmgraph.js.org/?q=deep-equal).

wesleytodd commented 1 month ago

I will copy my response here from content-type:

We do not typically like to take package swaps for this reason. Is there any functional reason to pursue this change? In this specific case we would decline this PR anyway because the package currently supports node's older than 6. Even when we move past that hurdle, I don't see a reason to change this dependency based solely on how many transitives it brings in.

I would suggest bringing up this kind of change in https://github.com/expressjs/discussions/ before opening more PRs to Express run packages and wasting more time.