Tests using deep-equal won't fail

jshttp / content-disposition

Create and parse HTTP Content-Disposition header

MIT License

224 stars 43 forks source link

Tests using deep-equal won't fail #38

Closed alex7kom closed 2 years ago

alex7kom commented 3 years ago

Some tests in this project use deep-equal module instead of assert.deepEqual(), however deep-equal never throws, it just returns a boolean, so the tests with just deep-equal will never fail. Tests with deep-equal should probably use assert.ok().

dougwilson commented 2 years ago

Wow, you are right. Great catch!