cookies

[jonathanong]

needs keygrip to be finished and moved to crypto-utils. then v1!

if anyone wants to speed this up, do a code review please :) i've been waiting on one forever...

[dougwilson]

so, i was thinking about cookies, and to me, it seems (like sure what the module names would be) that we should probably have a module that just reads/writes the raw cookie headers (cookie and set-cookie) and then another that layers on top with extras like signing and encryption.

[jonathanong]

i think the lower level ones should be get-cookie and set-cookie. in particular, i want to get rid or thoroughly test this thing: https://github.com/expressjs/cookies/blob/master/lib/cookies.js#L126

cookies itself (and any generic name like that) should be the user-facing lib imo

[jonathanong]

now that we have cookie as well as cookies, how do we intend to split up cookies now? or should they just be different APIs to even lower-level modules?

/cc @defunctzombie

[defunctzombie]

I think the cookie module can do the low level stuff and the high level stuff is indeed a separate module.

[dougwilson]

I'm sort of thinking cookie should be the low-level module that just does the reads/writes of the raw cookie headers (cookie and set-cookie) and then cookies is the one that layers on top with extras like signing and encryption or somehing.

[dougwilson]

also, @defunctzombie , i know you moved the module in here, but i was wondering what you felt your role should be: do you want to continue to be the lead maintainer of the module, or do you feel like you donated the module to jshttp?

[defunctzombie]

@dougwilson didn't really think too much about that honestly because the code for this module does not change that much (as seen from the commits). Unless there is a compelling reason to change it, I see the module as finalized (with exception of this raw mode maybe). I think my role can remain what it is with some of the other modules, I just watch and chime in. Certainly I should not be a blocker for forward progress and moving to jshttp indicates I trust the judgement here :)

[dougwilson]

@defunctzombie ok, I was just checking :) I agree, it's pretty much finalized, though I haven't yet scrutinized it :)

[jonathanong]

[defunctzombie]