Closed mathiasbynens closed 2 years ago
src/iana-types.json
diff caused by these changes.Hello, and thank you for this PR. I'm not seeing any different behavior before or after your PR, and the default redirects for the cogent
module we used in 3, which is larger than you are setting here. Is there a particular reason this should only allow up to 2 redirects instead of the default 3 redirects? https://github.com/cojs/cogent/blob/master/lib/index.js#L20
Ah, as stated in the commit message, my assumption was that cogent defaults to following only 1 redirect. I got that from this README, which states:
redirects
- resolve redirects, default1
If the true default is indeed 3
then we don’t actually need this. Feel free to close this.
Ah, yes, hmm... so I pulled down this PR and ran the scripts and there doesn't seem to be any different behavior. Was this supposed to fix something / what difference should I see with this change?
I assumed that this was the cause of the newer entries w.r.t. RFC 9239 not showing up. I guess that was wrong :)
Certain URLs of the form
https://tools.ietf.org/rfc/${RFC_ID}.txt
redirect multiple times before arriving to the canonical resource. Example:cogent
’s implicit default is to only follow 1 redirect. This patch explicitly configurescogent
to follow up to two redirects.This is required to properly fetch RFC 9239 and update the JavaScript MIME type entries.
Issue: #194, #262