search

jshttp / mime-db

Media Type Database
MIT License
1.09k stars 256 forks source link

Fix pin versions nyc version for testing on old versions of node <= 9 #318

Closed carpasse closed 5 months ago

carpasse commented 5 months ago

Closes #317 Same fix as jshttp/http-errors#109

carpasse commented 5 months ago

I've also removed Node.js v0.6 from the ci-tests GH action because it fails to install. I've checked the ci-tests action in http-errors and it is not there probably because of similar reasons.

Screenshot 2024-03-26 at 10 06 08
carpasse commented 5 months ago

Node 0.6 run was probably canceled because the other builds failed. I will add it back and test.

carpasse commented 5 months ago

The build doesn't seem to finish after adding back node version 0.6 I had to cancel it after 8 min https://github.com/carpasse/mime-db/actions/runs/8433679841/job/23095235917

Screenshot 2024-03-26 at 10 38 59

@dougwilson @UlisesGascon should I remove node.js version 0.6 from the ci-tests? It will be in sync with http-errors ci-tests.yml action

UlisesGascon commented 5 months ago

I enabled CI to run on this PR. Let's see how the patch works :+1: