search

jshttp / mime-db

Media Type Database
MIT License
1.09k stars 256 forks source link

đŸ¤–Automated update #328

Closed github-actions[bot] closed 1 month ago

github-actions[bot] commented 1 month ago

This PR contains automated updates from running npm run update

jonchurch commented 1 month ago

good bot

Had to change base branch, bc we were triggering this manually from the branch we were working off of to fix the action at the time.

wesleytodd commented 1 month ago

Now that it is merged we should re-kick off the action and make sure this PR is clean with just the updates from the mime type changes and not the action changes itself.

davidmarkclements commented 1 month ago

@wesleytodd @jonchurch I think it's important to note that this should have been a major release, changing mime-types for .js/.mjs from application/javascript to text/javascript is a breaking change (I know it's breaking because we just traced our breakage to this)

wesleytodd commented 1 month ago

Hey! This package has never treated mime changes in the data as part of the semver contract. We have a discussion here about this topic you can read if you like: https://github.com/jshttp/mime-types/pull/126

Additionally, I will open a PR to this package with a similar readme addition. I totally understand the concern, and I had the same concern, but it was not this PR that broke it it was this one: https://github.com/jshttp/mime-db/pull/262

Which was merged before the new group took over the project, but we all agree that keeping semver with externally sourced data is untennable. Going forward if this is a concern for you this package needs to be pinned in your project (and I will add the docs to make that clear for folks if they were not clear previously).