search

jshttp / negotiator

An HTTP content negotiator for Node.js
MIT License
314 stars 34 forks source link

Ported to JS #1

Closed isaacs closed 12 years ago

isaacs commented 12 years ago

This was the only fully complete content negotiation library I could find. However, it's in CoffeeScript, and not precompiled, and also uses underscore a bit unnecessarily, making it not optimal for my use.

So, I ported it to JS. The result is not so bad. There are some parts that could still be a bit more abstracted out for greater DRY-ness, but they're pretty minimal.

I know sometimes people convert libs back and forth out of trollish desires, but that's not my goal here at all. I really just wanted to use this library without having to load coffee-script at run time. I changed the name, and republished it as "negotiator.js" to differentiate it: https://github.com/isaacs/negotiator.js

If you are interested in merging the two, I will be happy to continue maintaining it. If not, then feel free to close this issue, and we can live side by side in peace :)

federomero commented 12 years ago

I think merging the two is a good idea, would you like me to add you as a collaborator to this repo?

isaacs commented 12 years ago

Sure, either that, or I can send you a pull req. Are you saying that you'd be ok with it being just a JavaScript thing, and lose the coffee-script dep?

federomero commented 12 years ago

Yes, I don't mind it being just javascript.

isaacs commented 12 years ago

Ok, awesome! I'll change the name back, then, and remove my renamed version from npm and githuib.