bug with type-is

[HenryGau]

Hi,

The background: Alipay system is sending a POST request with header of: content-type: application/x-www-form-urlencoded; text/html; charset=utf-8

after using bodyparser with type-is internally, there is a big issue: current behavior

var is   = require('type-is')
var mediaType = 'application/x-www-form-urlencoded; text/html; charset=utf-8'
is.is(mediaType, ['*/*']) // returning false and rejecting my content/body

expected behavior

is.is(mediaType, ['*/*']) // should return application/x-www-form-urlencoded ??

@didayche

[jonathanong]

i'm pretty sure that's an invalid content type

[HenryGau]

even so,

'*/*' 

should still match it, right?

[dougwilson]

Currently we specifically don't match any invalid content type, which is why your match fails.

[dougwilson]

Think about it: body-parser needs to parse the charset from the type. If the type is malformed (like your example), then anything it would get would be meaningless. The answer is that you either need to send a valid content type, or add a middleware prior to body-parser to clean up the content-type header so it's valid.

[dougwilson]

In fact, the body-parser module accepts a function as the type option which allows you to implement whatever logic you like, avoiding this library. Please see the body-parser readme for more information / open an issue for help over at body-parser, please.

[HenryGau]

Thanks, I will use that function from body-parser then. The only confusion is when using wildcard, '/', I thought it will match any content type having '/' character without validity check.

I added some more text in Readme here to clarify the logic you already have: https://github.com/jshttp/type-is/pull/13

[dougwilson]

Gotcha. It does match any content type. Would you have expected it to match foo/bar/baz as well? If not, then you are already agreeing that it should do validation.

Basically since the header is a string, it could be anything. HTTP defines the exact syntax of a content type, so we validate that the string is one so we can compare apples to apples.