jshuaf / Aquaforces

The land of the free
0 stars 0 forks source link

Errors pop out when playing #114

Open ssneilss opened 8 years ago

ssneilss commented 8 years ago

Process

jshuaf commented 8 years ago

Yeah just realized that's a failing with my implementation.

Basically you shouldn't have two answers on the screen at the same time that are the same. I basically just hacked around it by saying if the set was really small, having duplicate answers was oK.

Problem - that also leads to duplicate keys as I was using the index of the answer from the original data as React's key.

We really just need a minimum set size. For now, we could change the key to a random number in a sufficiently large range.

ssneilss commented 8 years ago

Got it. I think I can import some question sets manually copied from pagamo