jsiegenthaler / homebridge-eosstb

A homebridge plugin for the EOS set-top box as used by Sunrise, Telenet, Ziggo, Virgin Media and maybe more in various countries on the Horizon Go (HGO) platform
https://github.com/jsiegenthaler/homebridge-eosstb
32 stars 4 forks source link

Netflix does not display as channel name once Netflix is running #34

Closed jsiegenthaler closed 3 years ago

jsiegenthaler commented 3 years ago

Describe The Bug:

Netflix does not display as channel name once Netflix is running

To Reproduce:

  1. Setup a profile which includes Netflix
  2. Ensure the Netflix channelId and channelName are added to your channels config
  3. Select Netflix from the channel list
  4. Observe that the channel on the set-top box changes successfully to Netflix
  5. Observe that the TV platform now reports that Netflix app is running with a different app id
  6. Observe that the Netflix name is no longer displayed in the Home tile

Expected behavior:

Users expect Netflix to remain visible as the selected channel, as a user sees Netflix as a normal channel like other channels. Even though it is an app.

Logs:

Netflix is properly detected and added to the master channel list

[14/04/2021, 07:02:33] [EOSSTB] UPC TV_DEV: Found SV09690 in config channels, setting name to Netflix
[14/04/2021, 07:02:33] [EOSSTB] UPC TV_DEV: Unknown channel SV09690 [Netflix] discovered. Adding to the master channel list
[14/04/2021, 07:02:33] [EOSSTB] UPC TV_DEV: Channel list refreshed from profile 'Dad' with 30 channels

Here you see the Netflix app and its id once it is running

[13/04/2021, 18:40:45] [EOSSTB] mqttClient: mqttMessage.status.uiStatus: apps
[13/04/2021, 18:40:45] [EOSSTB] mqttClient: CPE.uiStatus: cpeUiStatus: {
  uiStatus: 'apps',
  appsState: {
    id: 'com.libertyglobal.app.netflix',
    appName: 'Netflix',
    logoPath: '//cdn.metrological.com/s/apps/com.libertyglobal.app.netflix/0.0.1-de02568/Image/1920x1080/icon.png',
    state: {}
  }
}
[13/04/2021, 18:40:45] [EOSSTB] mqttClient: CPE.uiStatus: cpeUiStatus.uiStatus: apps
[13/04/2021, 18:40:45] [EOSSTB] UPC TV_DEV: updateDeviceState: powerState undefined, mediaState undefined [undefined], , recordingState undefined [undefined], channelId com.libertyglobal.app.netflix, sourceType undefined, profileDataChanged undefined
[13/04/2021, 18:40:45] [EOSSTB] UPC TV_DEV: updateDeviceState: currentPowerState 1, currentMediaState 0 [PLAY], currentRecordingState 0 [IDLE], currentChannelId com.libertyglobal.app.netflix [Netflix], currentSourceType linear, currentClosedCaptionsState 0 [DISABLED], currentPictureMode 1 [STANDARD], profileDataChanged false

[13/04/2021, 18:45:44] [EOSSTB] UPC TV_DEV: getInput currentChannelId com.libertyglobal.app.netflix

Plugin Config:

            "channels": [
                {
                    "channelId": "SV09690",
                    "channelName": "Netflix"
                }
            ],
jimbo-l commented 3 years ago

This will probably apply to the Prime Video special (UK) channel too, I guess. I will test later.

jsiegenthaler commented 3 years ago

Yes, any "special" channel that uses a channel list entry to start an app will be affected

jsiegenthaler commented 3 years ago

Sometimes a complex problem can be solved simply: what if an appId was added to the channel config? That would avoid the nightmare of multiple configs per channel....

jsiegenthaler commented 3 years ago

Fixed in v1.1.7-beta.2 Please test. To test:

  1. Ensure that Netflix is in your profile that you use on your iOS device: either in the shared profile at positions <=95, or in a custom profile
  2. Switch back and forth between normal linear TV channels and the special app channel Netflix
  3. The displayed channel name in HomeKit should always be correct

I'll close this issue when I get confirmation from users

jsiegenthaler commented 3 years ago

Confirmed fixed in v1.1.7-beta.4 Will be released shortly