jsiegenthaler / homebridge-samsungtvht

Homebridge plugin for Samsung TV (D5000 series) and Home Theater (D5500 series) from ca 2011.
MIT License
13 stars 1 forks source link

Ping response keeps flooding the logs #8

Closed TheEngineerGuy closed 1 year ago

TheEngineerGuy commented 1 year ago

When there is a non-zero packet loss, (75%, 50% or 66.6667%) ping keeps on flooding the HB logs. So, for 90% of the day when TV is off, this plugin keeps on filling up logs with pointless info. Personally, I would rather have this level of logging in a higher verbosity, not at default level of 0.

For now uninstalling the plugin. Let me know if and when you wish for me to test a newer version.

jsiegenthaler commented 1 year ago

Good point. I’ll look in to this in a few weeks when I’m back home.

Regards Jochen

Sent from my iPhone 12Super

On 4 Sep 2022, at 22:01, TheEngineerGuy @.***> wrote:

 When there is a non-zero packet loss, (75%, 50% or 66.6667%) ping keeps on flooding the HB logs. So, for 90% of the day when TV is off, this plugin keeps on filling up logs with pointless info. Personally, I would rather have this level of logging in a higher verbosity, not at default level of 0.

For now uninstalling the plugin. Let me know if and when you wish for me to test a newer version.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

huddx01 commented 1 year ago

@TheEngineerGuy

Had exactly the same problem...

@jsiegenthaler Just change the line 187 in index.js from warn to debug:

self.log.warn("powerStateMonitor: WARNING %s cannot determine power state from ping result! stdout:", device.name, stdout);

to:

self.log.debug("powerStateMonitor: WARNING %s cannot determine power state from ping result! stdout:", device.name, stdout);

jsiegenthaler commented 1 year ago

Fixed in v0.1.19

TheEngineerGuy commented 1 year ago

Thank you! Testing it.