search

jsigbiz / spec

JavaScript signature notation
131 stars 6 forks source link

Rename Value -> Any #17

Closed Raynos closed 9 years ago

Raynos commented 9 years ago

The parser in Raynos/jsig uses the Any character instead of Value character to imply any value.

You previously mentioned in #13 that this is a reasonable change.

junosuarez commented 9 years ago

I read back through #13 trying to find the rationale, but couldn't see it. (If I missed it, could you please link me to the comment?).

I like this change because it is more explicit. For other primitive types, I was trying to stick to the ES5 spec whenever possible, but Value is not actually a symbol in ES5. In use (especially prior to writing the specification), I've found myself intuitively using both of these. If you have any other rationale for making this change, please document it below. If all's well, I'll merge this shortly.

Raynos commented 9 years ago

I don't know why i picked Any instead of Value.

I do feel that when using the phrase "any value" the Any symbol makes more sense.

It might also be typescripts fault, typescript also uses any.

Note scala also uses Any

wilmoore commented 9 years ago

Any

:+1: - When I read Value, that means nothing to me; however, when I read Any, the meaning is obvious. Also a bonus that TypeScript and Scala felt it was a good way to go.

Raynos commented 9 years ago

@jden mind if I merge this ?